Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Base Slider style revisions and final review #32140

Merged
merged 2 commits into from
Apr 6, 2022

Conversation

samuelsycamore
Copy link
Member

@samuelsycamore samuelsycamore commented Apr 5, 2022

This one was already mostly done before the final review so this is mostly just for style consistency. 🤝 I also introduced the term "thumb" earlier in the piece, and when placed in context I think it's easier to infer the meaning.

@samuelsycamore samuelsycamore added docs Improvements or additions to the documentation component: slider This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base labels Apr 5, 2022
@samuelsycamore samuelsycamore requested a review from a team April 5, 2022 21:45
@mui-bot
Copy link

mui-bot commented Apr 5, 2022

No bundle size changes

Generated by 🚫 dangerJS against f3de199

@siriwatknp siriwatknp merged commit 93fc11e into mui:master Apr 6, 2022
@samuelsycamore samuelsycamore deleted the base-slider-style-review branch April 3, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: slider This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants